toddmeng-db commented on code in PR #2842:
URL: https://github.com/apache/arrow-adbc/pull/2842#discussion_r2099065247
##########
csharp/test/Drivers/Databricks/StatementTests.cs:
##########
@@ -436,13 +436,12 @@ protected override void
PrepareCreateTableWithPrimaryKeys(out string sqlUpdate,
// NOTE: this is a thirty minute test. As of writing, databricks
commands have 20 minutes of idle time (and checked every 5 mintues)
[SkippableTheory]
- [InlineData(true, "CloudFetch enabled")]
- [InlineData(false, "CloudFetch disabled")]
+ [InlineData(true, "CloudFetch enabled")] // TODO: test cloudfetch
disabled
public async Task StatusPollerKeepsQueryAlive(bool useCloudFetch,
string configName)
Review Comment:
Removes cloudfetch heartbeat test: cloudfetch URLs are fetched during
CloudFetchReader initialization, and the URL expire swithin 15 minutes.
Delaying for 30 minutes will result in attempting to read expired urls. This
makes testing this really difficult.
@jadewang-db Do we need to do anything about this url expiration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
