kou commented on code in PR #46527:
URL: https://github.com/apache/arrow/pull/46527#discussion_r2099352672
##########
ci/scripts/python_wheel_unix_test.sh:
##########
@@ -96,13 +96,13 @@ if [ "${CHECK_VERSION}" == "ON" ]; then
fi
if [ "${CHECK_WHEEL_CONTENT}" == "ON" ]; then
- python ${source_dir}/ci/scripts/python_wheel_validate_contents.py \
- --path ${source_dir}/python/repaired_wheels
+ python "${source_dir}"/ci/scripts/python_wheel_validate_contents.py \
+ --path "${source_dir}"/python/repaired_wheels
Review Comment:
Why is `${source_dir}` only quoted?
##########
ci/scripts/python_wheel_unix_test.sh:
##########
@@ -96,13 +96,13 @@ if [ "${CHECK_VERSION}" == "ON" ]; then
fi
if [ "${CHECK_WHEEL_CONTENT}" == "ON" ]; then
- python ${source_dir}/ci/scripts/python_wheel_validate_contents.py \
- --path ${source_dir}/python/repaired_wheels
+ python "${source_dir}"/ci/scripts/python_wheel_validate_contents.py \
+ --path "${source_dir}"/python/repaired_wheels
fi
if [ "${CHECK_UNITTESTS}" == "ON" ]; then
# Install testing dependencies
- python -m pip install -U -r ${source_dir}/python/requirements-wheel-test.txt
+ python -m pip install -U -r
"${source_dir}"/python/requirements-wheel-test.txt
Review Comment:
Ditto.
##########
ci/scripts/python_wheel_unix_test.sh:
##########
@@ -59,7 +59,7 @@ export
PARQUET_TEST_DATA=${source_dir}/cpp/submodules/parquet-testing/data
if [ "${INSTALL_PYARROW}" == "ON" ]; then
# Install the built wheels
- python -m pip install ${source_dir}/python/repaired_wheels/*.whl
+ python -m pip install "${source_dir}"/python/repaired_wheels/*.whl
Review Comment:
I don't have a strong opinion. `"${source_dir}"` is OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
