scovich commented on code in PR #7535:
URL: https://github.com/apache/arrow-rs/pull/7535#discussion_r2104529271
##########
parquet-variant/src/utils.rs:
##########
@@ -0,0 +1,42 @@
+use std::{array::TryFromSliceError, ops::Range};
+
+use arrow_schema::ArrowError;
+
+#[inline]
+pub(crate) fn slice_from_slice(bytes: &[u8], range: Range<usize>) ->
Result<&[u8], ArrowError> {
+ bytes.get(range.clone()).ok_or_else(|| {
+ ArrowError::InvalidArgumentError(format!(
+ "Tried to extract {} bytes at offset {} from {}-byte buffer",
+ range.end - range.start,
+ range.start,
+ bytes.len(),
+ ))
Review Comment:
Update: If we go for the `SliceIndex` approach that just prints `{index:?}`
in the error message, we no longer need to worry about overflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
