raulcd commented on code in PR #46261:
URL: https://github.com/apache/arrow/pull/46261#discussion_r2104695197


##########
c_glib/arrow-glib/compute.cpp:
##########
@@ -37,6 +37,9 @@
 #include <arrow/acero/exec_plan.h>
 #include <arrow/acero/options.h>
 
+// Initialize the compute library and register compute kernels.
+auto compute_init_status_ = arrow::compute::Initialize();

Review Comment:
   we were always returning `Status::OK()` and the current function registry 
does not return or checks for errors registering so having 
`arrow::compute::Initialize()` not return `arrow::Status` makes sense to me.
   @pitrou @kou what do you think about this, I've pushed a commit with the new 
behavior:
   
https://github.com/apache/arrow/pull/46261/commits/13a20f02796e6bf38e68fb84f314d8faa61db350



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to