mapleFU commented on issue #46555:
URL: https://github.com/apache/arrow/issues/46555#issuecomment-2904893130

   @zeroshade This builder api sounds ok to me for primitive api, though I 
found maybe only integer will use smallest ( can float/double cannot distinct 
it fits the smallest type? Perhaps not? )
   
   I also wonder what the decimal value in builder api would be like, since 
arrow doesn't have Java's `BigDecimal` type. I draft a
   
   ```
   template<typename ArrowDecimalType>
   struct DecimalValue {
     ArrowDecimalType decimal;
      uint8_t scale;
   };
   ```
   
   What would here better being?
   
   Also, I've list a part for output and internal buffer handling. Arena like 
data structure would be used here. Previously I've think how to do think of 
reusing buffer and making build array of Variant vectorization. But now I found 
it's complex to vectorize building a so complex type. So maybe I should focous 
on reuse buffer and decrease dynamic buffer allocation


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to