ianmcook commented on a change in pull request #9909:
URL: https://github.com/apache/arrow/pull/9909#discussion_r608161039



##########
File path: r/tests/testthat/test-dplyr-filter.R
##########
@@ -283,7 +283,8 @@ test_that("filter environment scope", {
   )
   # Also for functions
   # 'could not find function "isEqualTo"' because we haven't defined it yet
-  expect_dplyr_error(filter(batch, isEqualTo(int, 4)))
+  expect_dplyr_error(filter(batch, isEqualTo(int, 4)), tbl)

Review comment:
       @jonkeane despite the comment in the definition of 
`expect_dplyr_error()` saying that the expression should be
   >A dplyr pipeline with `input` as its start
   
   It does not actually need to _start_ with `input`. So the use of the pipe 
vs. the first-argument here is not significant. The replacement of `batch` with 
`input` _is_ of course significant.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to