alamb commented on code in PR #7541:
URL: https://github.com/apache/arrow-rs/pull/7541#discussion_r2105082947
##########
parquet/src/arrow/arrow_reader/read_plan.rs:
##########
@@ -112,10 +112,9 @@ impl ReadPlanBuilder {
};
}
- let raw = RowSelection::from_filters(&filters);
self.selection = match self.selection.take() {
- Some(selection) => Some(selection.and_then(&raw)),
- None => Some(raw),
+ Some(selection) => Some(selection.apply_filters(&filters)),
Review Comment:
The whole point of this PR is to call `apply_filters` here and avoid
creating `raw` when there is an existing filter.
I will run some benchmarks and see
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
