mapleFU commented on code in PR #46372: URL: https://github.com/apache/arrow/pull/46372#discussion_r2105481208
########## cpp/src/parquet/variant.cc: ########## @@ -0,0 +1,779 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "parquet/variant.h" + +#include <cstdint> +#include <iostream> +#include <string_view> + +#include <arrow/util/endian.h> +#include <arrow/util/logging.h> +#include <arrow/util/unreachable.h> + +#include "parquet/exception.h" + +namespace parquet::variant { + +std::string VariantBasicTypeToString(VariantBasicType type) { + switch (type) { + case VariantBasicType::Primitive: + return "Primitive"; + case VariantBasicType::ShortString: + return "ShortString"; + case VariantBasicType::Object: + return "Object"; + case VariantBasicType::Array: + return "Array"; + default: + return "Unknown"; + } +} + +std::string VariantPrimitiveTypeToString(VariantPrimitiveType type) { + switch (type) { + case VariantPrimitiveType::NullType: + return "NullType"; + case VariantPrimitiveType::BooleanTrue: + return "BooleanTrue"; + case VariantPrimitiveType::BooleanFalse: + return "BooleanFalse"; + case VariantPrimitiveType::Int8: + return "Int8"; + case VariantPrimitiveType::Int16: + return "Int16"; + case VariantPrimitiveType::Int32: + return "Int32"; + case VariantPrimitiveType::Int64: + return "Int64"; + case VariantPrimitiveType::Double: + return "Double"; + case VariantPrimitiveType::Decimal4: + return "Decimal4"; + case VariantPrimitiveType::Decimal8: + return "Decimal8"; + case VariantPrimitiveType::Decimal16: + return "Decimal16"; + case VariantPrimitiveType::Date: + return "Date"; + case VariantPrimitiveType::TimestampMicros: + return "TimestampMicros"; + case VariantPrimitiveType::TimestampMicrosNtz: + return "TimestampMicrosNtz"; + case VariantPrimitiveType::Float: + return "Float"; + case VariantPrimitiveType::Binary: + return "Binary"; + case VariantPrimitiveType::String: + return "String"; + case VariantPrimitiveType::TimeMicrosNtz: + return "TimeMicrosNtz"; + case VariantPrimitiveType::TimestampNanosTz: + return "TimestampNanosTz"; + case VariantPrimitiveType::TimestampNanosNtz: + return "TimestampNanosNtz"; + case VariantPrimitiveType::Uuid: + return "Uuid"; + default: + return "Unknown"; + } +} + +std::string VariantTypeToString(VariantType type) { + switch (type) { + case VariantType::Object: + return "Object"; + case VariantType::Array: + return "Array"; + case VariantType::Null: + return "Null"; + case VariantType::Boolean: + return "Boolean"; + case VariantType::Int8: + return "Int8"; + case VariantType::Int16: + return "Int16"; + case VariantType::Int32: + return "Int32"; + case VariantType::Int64: + return "Int64"; + case VariantType::String: + return "String"; + case VariantType::Double: + return "Double"; + case VariantType::Decimal4: + return "Decimal4"; + case VariantType::Decimal8: + return "Decimal8"; + case VariantType::Decimal16: + return "Decimal16"; + case VariantType::Date: + return "Date"; + case VariantType::TimestampMicrosTz: + return "TimestampMicrosTz"; + case VariantType::TimestampMicrosNtz: + return "TimestampMicrosNtz"; + case VariantType::Float: + return "Float"; + case VariantType::Binary: + return "Binary"; + case VariantType::Time: + return "Time"; + case VariantType::TimestampNanosTz: + return "TimestampNanosTz"; + case VariantType::TimestampNanosNtz: + return "TimestampNanosNtz"; + case VariantType::Uuid: + return "Uuid"; + default: + return "Unknown"; + } +} + +inline uint32_t readLittleEndianU32(const void* from, uint8_t size) { + ARROW_DCHECK_LE(size, 4); + ARROW_DCHECK_GE(size, 1); + + uint32_t result = 0; + memcpy(&result, from, size); + return ::arrow::bit_util::FromLittleEndian(result); +} + +VariantMetadata::VariantMetadata(std::string_view metadata) : metadata_(metadata) { + if (metadata.size() < kHeaderSizeBytes + kMinimalOffsetSizeBytes * 2) { + // Empty metadata is at least 3 bytes: version, dictionarySize and + // at least one offset. + throw ParquetException("Invalid Variant metadata: too short: size=" + + std::to_string(metadata.size())); + } + if (version() != kSupportedVersion) { + // Currently we only supports version 1. + throw ParquetException("Unsupported Variant metadata version: " + + std::to_string(version())); + } + uint8_t offset_sz = offset_size(); + if (offset_sz < kMinimalOffsetSizeBytes || offset_sz > kMaximumOffsetSizeBytes) { + throw ParquetException("Invalid Variant metadata: invalid offset size: " + + std::to_string(offset_sz)); + } + dictionary_size_ = loadDictionarySize(metadata, offset_sz); + if (kHeaderSizeBytes + (dictionary_size_ + 2) * offset_sz > metadata_.size()) { + throw ParquetException( + "Invalid Variant metadata: offset out of range: " + + std::to_string((dictionary_size_ + kHeaderSizeBytes) * offset_sz) + " > " + + std::to_string(metadata_.size())); + } Review Comment: In metadata I delayed the validating offsets to getter, it can also put here to validate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
