scovich commented on PR #7535: URL: https://github.com/apache/arrow-rs/pull/7535#issuecomment-2906015547
> In my opinion the only outstanding questions are some of the details of handling Objects and arrays but I think we can iterate on that in subsequent PRs as we haven't really committed to an API > > What do you think @mkarbo and @scovich ? Is this good enough to merge and make follow on PRs? We're getting very close. I agree the specifics of objects and arrays can be follow-on work. A few remaining items on my mind (some of which are comments that github oh-so-helpfully hides): * How much "extra" validation (= not immediately needed by the function that performs it) should we be doing? See https://github.com/apache/arrow-rs/pull/7535#discussion_r2105503464 * The `VariantMetadata` API seems overly wide and complex, I wonder if we can simplify it? See https://github.com/apache/arrow-rs/pull/7535#discussion_r2105467545 * Significant code simplifications still seem to be possible. A good chunk of this is IMO due to the previous two points. I'm interested in this because we're still finding ways to factor out redundant code to helper functions that will likely make the remaining pathfinding easier; also because this is very complex stuff, and the less code we express it in the smaller the cognitive burden and bug surface will be. Plus, it's something that gets harder and harder to fix later as the code grows and matures. I suspect one more pass will address the code simplifications. Not sure how to resolve the other two most efficiently? Maybe others could chime in so we have more voices to consider? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
