zeroshade commented on issue #372: URL: https://github.com/apache/arrow-go/issues/372#issuecomment-2908079808
Are you suggesting this should be done for all Nested builders? Or just for the record builder and validating only the top level of columns? My concern on this is when dealing with a non-nullable field within a nullable struct type. Adding null elements to the parent struct array necessitates adding nulls to a child which would be technically marked as non-null (or would require changing the implementation to notice this situation and to just add empty/zero values instead) causing existing code that is technically correct to potentially fail if we add this check to all nested builders. But if this check is *only* for the top level columns of a record batch, that wouldn't be a concern. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
