kou commented on code in PR #43439:
URL: https://github.com/apache/arrow/pull/43439#discussion_r2107172645
##########
swift/Arrow/Sources/Arrow/ArrowWriterHelper.swift:
##########
@@ -25,85 +25,90 @@ extension Data {
}
func toFBTypeEnum(_ arrowType: ArrowType) ->
Result<org_apache_arrow_flatbuf_Type_, ArrowError> {
- let infoType = arrowType.info
- if infoType == ArrowType.ArrowInt8 || infoType == ArrowType.ArrowInt16 ||
- infoType == ArrowType.ArrowInt64 || infoType == ArrowType.ArrowUInt8 ||
- infoType == ArrowType.ArrowUInt16 || infoType == ArrowType.ArrowUInt32
||
- infoType == ArrowType.ArrowUInt64 || infoType == ArrowType.ArrowInt32 {
+ let typeId = arrowType.id
+ switch arrowType.id {
Review Comment:
```suggestion
switch typeId {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
