pitrou commented on code in PR #46532:
URL: https://github.com/apache/arrow/pull/46532#discussion_r2108613550
##########
cpp/src/parquet/arrow/reader.cc:
##########
@@ -451,8 +452,17 @@ class LeafReader : public ColumnReaderImpl {
field_(std::move(field)),
input_(std::move(input)),
descr_(input_->descr()) {
+ const auto type_id = field_->type()->id();
+ // If binary-like, RecordReader is able to read directly as the concrete
type
+ // so as to avoid offset limitations.
+ std::shared_ptr<DataType> type_for_reading =
Review Comment:
It sounds a bit pointless. Is the `LeafReader` constructor
performance-critical?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
