eric-wang-1990 commented on code in PR #2845:
URL: https://github.com/apache/arrow-adbc/pull/2845#discussion_r2109795687
##########
csharp/src/Drivers/Databricks/DatabricksConnection.cs:
##########
@@ -63,6 +64,27 @@ public DatabricksConnection(IReadOnlyDictionary<string,
string> properties) : ba
private void ValidateProperties()
{
+ if
(Properties.TryGetValue(DatabricksParameters.EnableMultipleCatalogSupport, out
string? enableMultipleCatalogSupportStr))
+ {
+ if (bool.TryParse(enableMultipleCatalogSupportStr, out bool
enableMultipleCatalogSupportValue))
+ {
+ _enableMultipleCatalogSupport =
enableMultipleCatalogSupportValue;
+ }
+ // PowerBI will pass in "1" and "0" as strings, so we need to
handle that
Review Comment:
The existing Power BI connector passed in "0", "1" etc, do you recommend
changing the connector code to overwrite as true/false rather than handle here
in the driver?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
