kou commented on code in PR #46657:
URL: https://github.com/apache/arrow/pull/46657#discussion_r2118250344
##########
ci/scripts/integration_spark.sh:
##########
@@ -18,9 +18,13 @@
# exit on any error
set -eu
+# SC2034 (warning): source_dir appears unused.
+# shellcheck disable=SC2034
source_dir=${1}
Review Comment:
It seems that the first argument is Spark version:
https://github.com/apache/arrow/blob/f1c6619332a280625a2381b03b2fd4a0722db82f/ci/docker/conda-python-spark.dockerfile#L37-L40
##########
ci/scripts/install_conda.sh:
##########
@@ -27,19 +27,21 @@ fi
arch=$(uname -m)
platform=$(uname)
installer=$1
+# SC2034 (warning): version appears unused.
+# shellcheck disable=SC2034
version=$2
prefix=$3
download_url=https://github.com/conda-forge/miniforge/releases/latest/download/${installer^}-${platform}-${arch}.sh
Review Comment:
We can use `version` here:
```suggestion
download_url=https://github.com/conda-forge/miniforge/releases/${version}/download/${installer^}-${platform}-${arch}.sh
```
##########
ci/scripts/nanoarrow_build.sh:
##########
@@ -19,6 +19,8 @@
set -e
+# SC2034 (warning): arrow_dir appears unused.
+# shellcheck disable=SC2034
arrow_dir=${1}
source_dir=${1}/nanoarrow
Review Comment:
This should use `${arrow_dir}` not `${1}`.
##########
ci/scripts/integration_spark.sh:
##########
@@ -35,7 +39,7 @@ fi
export MAVEN_OPTS="-Xss256m -Xmx2g -XX:ReservedCodeCacheSize=1g
-Dorg.slf4j.simpleLogger.defaultLogLevel=warn"
export MAVEN_OPTS="${MAVEN_OPTS}
-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn"
-pushd ${spark_dir}
+pushd "${spark_dir}"
echo "Building Spark ${SPARK_VERSION}"
Review Comment:
We can use `spark_version` not `SPARK_VERSION`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
