ianmcook commented on a change in pull request #9893:
URL: https://github.com/apache/arrow/pull/9893#discussion_r608705293
##########
File path: r/R/feather.R
##########
@@ -144,17 +144,20 @@ write_feather <- function(x,
#' }
read_feather <- function(file, col_select = NULL, as_data_frame = TRUE, ...) {
if (!inherits(file, "RandomAccessFile")) {
- file <- make_readable_file(file)
+ file <- make_readable_file(file, ...)
Review comment:
~~`FeatherReader` is an exported object with a docs entry, so this link
will work fine. There is no need to change the `@param ...` entry.~~
Correction: I see now that you're passing `...` to a different function, which
_is_ internal. In that case, I think putting the function name in backticks
without a link is good 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
