hiroyuki-sato commented on code in PR #46682:
URL: https://github.com/apache/arrow/pull/46682#discussion_r2122466717
##########
ci/scripts/r_build.sh:
##########
@@ -24,6 +24,12 @@ build_dir=${2}
: "${BUILD_DOCS_R:=OFF}"
+if [ -z "${INSTALL_ARGS}" ] ; then
+ R_INSTALL_ARGS=()
+else
+ read -r -a R_INSTALL_ARGS <<< "$INSTALL_ARGS"
+fi
Review Comment:
`for arg in ${INSTALL_ARGS};` violates `SC2153`.
```
for arg in ${INSTALL_ARGS}; do
^-------------^ SC2153 (info): Possible misspelling: INSTALL_ARGS
may not be assigned. Did you mean R_INSTALL_ARGS?
For more information:
https://www.shellcheck.net/wiki/SC2153 -- Possible misspelling:
INSTALL_ARG...
```
`for arg in "${INSTALL_ARGS}"` also violates `SC2066`.
```
for arg in "${INSTALL_ARGS}"; do
^---------------^ SC2066 (error): Since you double quoted this,
it will not word split, and the loop will only run once.
^-------------^ SC2153 (info): Possible misspelling:
INSTALL_ARGS may not be assigned. Did you mean R_INSTALL_ARGS?
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
