CookiePieWw commented on code in PR #7574:
URL: https://github.com/apache/arrow-rs/pull/7574#discussion_r2122610776
##########
parquet/tests/arrow_reader/mod.rs:
##########
@@ -987,6 +991,33 @@ fn create_data_batch(scenario: Scenario) ->
Vec<RecordBatch> {
make_utf8_batch(vec![Some("e"), Some("f"), Some("g"),
Some("h"), Some("i")]),
]
}
+ Scenario::TruncatedUTF8 => {
+ // Make utf8 batch with strings longer than 64 bytes
+ // to check truncation of row group statistics
+ vec![
+ make_utf8_batch(vec![
+ Some(&("a".repeat(64) + "1")),
+ Some(&("b".repeat(64) + "2")),
+ Some(&("c".repeat(64) + "3")),
Review Comment:
Sounds reasonable for me. But I still wonder if its as expected that a first
batch without null values will cause the `None`s in following batches are
converted into empty strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
