Dandandan commented on code in PR #7513:
URL: https://github.com/apache/arrow-rs/pull/7513#discussion_r2123382181
##########
arrow-array/src/builder/generic_bytes_view_builder.rs:
##########
@@ -406,6 +459,122 @@ impl<T: ByteViewType + ?Sized> GenericByteViewBuilder<T> {
};
buffer_size + in_progress + tracker + views + null
}
+
+ /// Append all views from the given array into the inprogress builder
+ ///
+ /// Will copy the underlying views based on the value of
target_buffer_load_factor
+ pub fn append_array(&mut self, array: &GenericByteViewArray<T>) {
Review Comment:
This can be used in `concat` as well (a similar implementation is almost
1.5x as fast on string views
##########
arrow-array/src/builder/generic_bytes_view_builder.rs:
##########
@@ -406,6 +459,122 @@ impl<T: ByteViewType + ?Sized> GenericByteViewBuilder<T> {
};
buffer_size + in_progress + tracker + views + null
}
+
+ /// Append all views from the given array into the inprogress builder
+ ///
+ /// Will copy the underlying views based on the value of
target_buffer_load_factor
+ pub fn append_array(&mut self, array: &GenericByteViewArray<T>) {
Review Comment:
This can be used in `concat` as well (a similar implementation is almost
1.5x as fast on string views)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
