andishgar commented on code in PR #46422: URL: https://github.com/apache/arrow/pull/46422#discussion_r2123771226
########## cpp/src/arrow/array/statistics_test.cc: ########## @@ -15,9 +15,12 @@ // specific language governing permissions and limitations // under the License. +#include <cmath> + #include <gtest/gtest.h> #include "arrow/array/statistics.h" +#include "arrow/compare.h" Review Comment: According to the Google C++ Style Guide, we should not rely on [transitive includes](https://google.github.io/styleguide/cppguide.html#Include_What_You_Use). _Do not rely on transitive inclusions. This allows people to remove no-longer-needed #include statements from their headers without breaking clients. This also applies to related headers - foo.cc should include bar.h if it uses a symbol from it even if foo.h includes bar.h_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
