Ziy1-Tan opened a new pull request, #46692:
URL: https://github.com/apache/arrow/pull/46692
### Rationale for this change
When reviewing the output of ClangBuildAnalyzer, it appears that the
arrow/array/data.h header is considered to be the most expensive include:
```
**** Expensive headers:
157903 ms: /home/simple/code/cpp/arrow/cpp/src/arrow/array/data.h (included
388 times, avg 406 ms), included via:
78x: array.h array_base.h
21x: array_base.h
21x: exec_plan.h exec.h
15x: test_util.h extension_type.h array_base.h
10x: api_scalar.h datum.h
10x: api_aggregate.h datum.h
...
122962 ms:
/home/simple/code/cpp/arrow/cpp/build/_deps/googletest-src/googletest/include/gtest/gtest.h
(included 235 times, avg 523 ms), included via:
124x: <direct include>
45x: gmock.h gmock-actions.h gmock-internal-utils.h
29x: gmock-matchers.h gmock-internal-utils.h
10x: gtest_util.h
6x: test_util_internal.h gmock.h gmock-actions.h gmock-internal-utils.h
3x: test_common.h gtest_util.h
...
113797 ms: /home/simple/code/cpp/arrow/cpp/src/arrow/array/statistics.h
(included 390 times, avg 291 ms), included via:
78x: array.h array_base.h data.h
21x: array_base.h data.h
21x: exec_plan.h exec.h data.h
15x: test_util.h extension_type.h array_base.h data.h
10x: api_aggregate.h datum.h data.h
10x: api_scalar.h datum.h data.h
...
```
### What changes are included in this PR?
- Replace "data.h" header with `ArrayData` foward declarations
- Replace "statistics.h" header with `ArrayStatistics`foward declarations
### Are these changes tested?
Manually build pass.
### Are there any user-facing changes?
No, only an API improvement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
