pitrou commented on PR #46530: URL: https://github.com/apache/arrow/pull/46530#issuecomment-2940407895
A more general comment. The approach in this PR is a bit inflexible, as any implementation-specific setting is exposed as a dedicated CLI options. This may proliferate CLI options as we need more settings to be exposed. For example, some per-implementation skips are currently hardcoded in the data generation ([example](https://github.com/apache/arrow/blob/832bfa1ec67c3a6d43dab5abe7d84271680fee9c/dev/archery/archery/integration/datagen.py#L1901-L1916)). Perhaps we would like an external implementation to tell which tests it needs to skip. That will complicate the CLI quite a bit. Another possibility is to allow passing a custom YAML file that records all the implementation-specific settings. The CLI would only have one additional argument and the YAML would carry the rest of the information in a structured way. But of course, Sparrow might remain the only user of this functionality, so it's also up to you. What do you think @Alex-PLACET ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
