birschick-bq commented on code in PR #2825:
URL: https://github.com/apache/arrow-adbc/pull/2825#discussion_r2127464276
##########
go/adbc/driver/internal/driverbase/connection.go:
##########
@@ -183,28 +188,34 @@ func (base *ConnectionImplBase) GetInfo(ctx
context.Context, infoCodes []adbc.In
} else {
strInfoBldr.AppendNull()
}
+ span.SetAttributes(attribute.String(code.String(), v))
Review Comment:
@lidavidm
With this
[commit](https://github.com/apache/arrow-adbc/pull/2825/commits/f3078c02bbf70dcb56371cfe2592d93a27fd4015),
I've tried to address the issue of how to add attributes for the driver info.
I've put it in the database.Open call and created attribute names that I think
are appropriate.
Let me know if this is what you had in mind.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
