Re: [PR] [Variant] Add commented out primitive test casees [arrow-rs]

[via GitHub]

alamb commented on code in PR #7631:
URL: https://github.com/apache/arrow-rs/pull/7631#discussion_r2135722698


##########
parquet-variant/tests/variant_interop.rs:
##########
@@ -40,16 +40,29 @@ fn load_case(name: &str) -> Result<(Vec<u8>, Vec<u8>), 
ArrowError> {
     Ok((meta, val))
 }
 
+/// Return a list of the values from the parquet testing repository:
+/// <https://github.com/apache/parquet-testing/tree/master/variant>
 fn get_primitive_cases() -> Vec<(&'static str, Variant<'static, 'static>)> {
+    // Cases are commented out
+    // Enabling is tracked in  https://github.com/apache/arrow-rs/issues/7630
     vec![
-        ("primitive_null", Variant::Null),
+        // ("primitive_binary", Variant::Binary),
         ("primitive_boolean_false", Variant::BooleanFalse),
         ("primitive_boolean_true", Variant::BooleanTrue),
+        // ("primitive_date", Variant::Null),
+        //("primitive_decimal4", Variant::Null),
+        //("primitive_decimal8", Variant::Null),
+        //("primitive_decimal16", Variant::Null),
+        //("primitive_float", Variant::Null),
         ("primitive_int8", Variant::Int8(42)),
-        // Using the From<String> trait

Review Comment:
   I removed this comment as it wasn't `From<String>` (it is `From<&str>`) and 
I felt using `Variant::String` and `Variant::ShortString` made the test more 
explicit and clear what the type was



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org