hiroyuki-sato opened a new pull request, #46766:
URL: https://github.com/apache/arrow/pull/46766

   ### Rationale for this change
   
   This is the sub issue #44748.
   
   * SC2086: (info): Double quote to prevent globbing and word splitting.
   * SC2129: Consider using { cmd1; cmd2; } >> file instead of individual 
redirects.
   
   ```
   shellcheck ci/scripts/ccache_setup.sh
   
   In ci/scripts/ccache_setup.sh line 22:
   echo "ARROW_USE_CCACHE=ON" >> $GITHUB_ENV
   ^-- SC2129 (style): Consider using { cmd1; cmd2; } >> file instead of 
individual redirects.
                                 ^---------^ SC2086 (info): Double quote to 
prevent globbing and word splitting.
   
   Did you mean:
   echo "ARROW_USE_CCACHE=ON" >> "$GITHUB_ENV"
   
   
   In ci/scripts/ccache_setup.sh line 23:
   echo "CCACHE_COMPILERCHECK=content" >> $GITHUB_ENV
                                          ^---------^ SC2086 (info): Double 
quote to prevent globbing and word splitting.
   
   Did you mean:
   echo "CCACHE_COMPILERCHECK=content" >> "$GITHUB_ENV"
   
   
   In ci/scripts/ccache_setup.sh line 24:
   echo "CCACHE_COMPRESS=1" >> $GITHUB_ENV
                               ^---------^ SC2086 (info): Double quote to 
prevent globbing and word splitting.
   
   Did you mean:
   echo "CCACHE_COMPRESS=1" >> "$GITHUB_ENV"
   
   
   In ci/scripts/ccache_setup.sh line 25:
   echo "CCACHE_COMPRESSLEVEL=6" >> $GITHUB_ENV
                                    ^---------^ SC2086 (info): Double quote to 
prevent globbing and word splitting.
   
   Did you mean:
   echo "CCACHE_COMPRESSLEVEL=6" >> "$GITHUB_ENV"
   
   
   In ci/scripts/ccache_setup.sh line 26:
   echo "CCACHE_MAXSIZE=1G" >> $GITHUB_ENV
                               ^---------^ SC2086 (info): Double quote to 
prevent globbing and word splitting.
   
   Did you mean:
   echo "CCACHE_MAXSIZE=1G" >> "$GITHUB_ENV"
   
   For more information:
     https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing 
...
     https://www.shellcheck.net/wiki/SC2129 -- Consider using { cmd1; cmd2; } 
>>...
   palolovalley:arrow hsato$ vi ci/scripts/ccache_setup.sh
   ```
   
   
   ### What changes are included in this PR?
   
   * SC2086: Quoting  like "$GITHUB_ENV"
   * SC2129: combine multiple commands using `{}`
   
   ### Are these changes tested?
   
   ### Are there any user-facing changes?
   
   **This PR includes breaking changes to public APIs.** (If there are any 
breaking changes to public APIs, please explain which changes are breaking. If 
not, you can remove this.)
   
   **This PR contains a "Critical Fix".** (If the changes fix either (a) a 
security vulnerability, (b) a bug that caused incorrect or invalid data to be 
produced, or (c) a bug that causes a crash (even when the API contract is 
upheld), please provide explanation. If not, you can remove this.)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to