raulcd commented on code in PR #46770:
URL: https://github.com/apache/arrow/pull/46770#discussion_r2137624465


##########
ci/scripts/python_build.sh:
##########
@@ -78,6 +78,13 @@ export PYARROW_PARALLEL=${n_jobs}
 export CMAKE_PREFIX_PATH
 export LD_LIBRARY_PATH=${ARROW_HOME}/lib:${LD_LIBRARY_PATH}
 
+# https://github.com/apache/arrow/issues/46516
+# If we are building docs we force Cython>3.1.1 to avoid numpydoc
+# failures due to Cython docstring being wrongly generated.
+if [ "${BUILD_DOCS_PYTHON}" == "ON" ]; then
+  ${PYTHON:-python} -m pip install --upgrade Cython>3.1.1

Review Comment:
   > Will that work properly if Cython was installed using conda?
   
   It does fix the existing failures which install Cython through conda, so the 
answer seems to be yes (without this it still fails) because the cached docker 
image installed Cython 3.1.1
   
   > Also, is this necessary at all?
   
   I don't think we should merge that specific change, I was validating the 
existing failing CI jobs.
   I think the bests course of action would be to force rebuild the underlying 
docker image so it is not caches and it installs Cython 3.1.2. I am asking on 
Zulip if someone has access to 
[docker.io/apache/arrow-dev](http://docker.io/apache/arrow-dev) as rebuilding 
the image would fix the issue



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to