WillAyd commented on code in PR #774:
URL: https://github.com/apache/arrow-nanoarrow/pull/774#discussion_r2138267338


##########
.github/workflows/build-and-test.yaml:
##########
@@ -175,6 +166,29 @@ jobs:
         run: |
           PKG_CONFIG_PATH="$(pwd)/arrow/lib/pkgconfig" 
ci/scripts/build-with-meson.sh
 
+  meson-build-windows:
+    runs-on: windows-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-python@v5
+        with:
+          python-version: '3.x'
+
+      # Meson 1.8.0 breaks build
+      # https://github.com/apache/arrow-nanoarrow/issues/753
+      - name: Install dependencies
+        run: |
+          python3 -m pip install --upgrade pip
+          python3 -m pip install "meson<1.8.0" ninja
+
+      - name: Run meson
+        run: |
+          meson setup builddir `

Review Comment:
   Would be nice to add -Werror here but it looks like the Windows build is 
failing with the same warning/error that we discussed in 
https://github.com/apache/arrow-nanoarrow/pull/763#issuecomment-2935648864
   
   I opened https://github.com/apache/arrow-nanoarrow/issues/775 to track



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to