pitrou commented on code in PR #45306:
URL: https://github.com/apache/arrow/pull/45306#discussion_r2139340571
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1016,17 +1016,44 @@ set(FC_DECLARE_COMMON_OPTIONS)
if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.28)
list(APPEND FC_DECLARE_COMMON_OPTIONS EXCLUDE_FROM_ALL TRUE)
endif()
+if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.25)
+ list(APPEND FC_DECLARE_COMMON_OPTIONS SYSTEM)
+endif()
macro(prepare_fetchcontent)
- set(BUILD_SHARED_LIBS OFF)
- set(BUILD_STATIC_LIBS ON)
- set(CMAKE_COMPILE_WARNING_AS_ERROR FALSE)
- set(CMAKE_EXPORT_NO_PACKAGE_REGISTRY TRUE)
- set(CMAKE_MACOSX_RPATH ${ARROW_INSTALL_NAME_RPATH})
+ set(BUILD_SHARED_LIBS
Review Comment:
Can you add a comment explaining why these have to be CACHE variables?
AFAIU, CACHE variables have a lot of side effects, so it's better to avoid them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
