hiroyuki-sato opened a new pull request, #46795:
URL: https://github.com/apache/arrow/pull/46795

   ### Rationale for this change
   
   This is the sub issue #44748.
   
   * SC2155: Declare and assign separately to avoid masking return values.
   * SC2086: Double quote to prevent globbing and word splitting.
   
   
   ```
   shellcheck ci/scripts/csharp_test.sh
   
   In ci/scripts/csharp_test.sh line 33:
   export PYTHONNET_PYDLL=$(${PYTHON} -m find_libpython)
          ^-------------^ SC2155 (warning): Declare and assign separately to 
avoid masking return values.
   
   
   In ci/scripts/csharp_test.sh line 35:
   pushd ${source_dir}
         ^-----------^ SC2086 (info): Double quote to prevent globbing and word 
splitting.
   
   Did you mean:
   pushd "${source_dir}"
   
   For more information:
     https://www.shellcheck.net/wiki/SC2155 -- Declare and assign separately to 
...
     https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing 
...
   ```
   
   ### What changes are included in this PR?
   
   * Declare and assign a variable separately.
   * Quoting like `"${source_dir}"`
   
   ### Are these changes tested?
   
   Yes.
   
   ### Are there any user-facing changes?
   
   No.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to