dinse commented on code in PR #46755:
URL: https://github.com/apache/arrow/pull/46755#discussion_r2144151695
##########
python/CMakeLists.txt:
##########
@@ -350,6 +350,11 @@ endif()
# PyArrow C++
set(PYARROW_CPP_ROOT_DIR pyarrow/src)
set(PYARROW_CPP_SOURCE_DIR ${PYARROW_CPP_ROOT_DIR}/arrow/python)
+
+# Write out compile-time configuration constants
+string(TOLOWER ${CMAKE_BUILD_TYPE} LOWERCASE_PYBUILD_TYPE)
+configure_file("${PYARROW_CPP_SOURCE_DIR}/pybuild_type.h.cmake"
"${PYARROW_CPP_SOURCE_DIR}/pybuild_type.h" ESCAPE_QUOTES)
Review Comment:
Ok, there is now config.h/.cc instead of doing this in helpers, and
config_internal.h.cmake.
##########
python/pyarrow/src/arrow/python/helpers.cc:
##########
@@ -499,6 +500,14 @@ bool IsThreadingEnabled() {
#endif
}
+namespace {
+ const std::string kPyBuildType = PYARROW_CYTHON_BUILD_TYPE;
+}
+
+std::string GetPyBuildType() {
+ return kPyBuildType;
+}
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
