alamb commented on PR #7467: URL: https://github.com/apache/arrow-rs/pull/7467#issuecomment-2970490439
> I guess we theoretically could, but that seems inconsistent with the rest of the codebase and it could cause unexpected failure and behavior without the remaining changes of this PR. > > @alamb how do you propose we continue with this? I'm happy to rebase and fix the remaining things, if we can agree on the general trajectory of continuing with this strategy. I like @adriangb 's suggestion to try to break this PR up into smaller changes as it will be easier to review. Specifically I think it will be easier to achieve what @tustvold describes as: > disentangle what this PR is actually changing I am finding this PR hard to review because I feel it is hard to understand the implications of the change (on compatibility, performance, etc). Smaller PRs might make that easier However, there might also be no way to break it up smaller . Some thoughts I had: 1. changes to flight in one PR 2. changes to the integration test (to ignore / stop using the ipc fields) 3. changes to the reader/writer 4. Then remove the fields -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
