etseidl commented on code in PR #7687:
URL: https://github.com/apache/arrow-rs/pull/7687#discussion_r2154847593
##########
parquet/src/data_type.rs:
##########
@@ -33,7 +33,7 @@ use crate::util::bit_util::FromBytes;
/// Rust representation for logical type INT96, value is backed by an array of
`u32`.
/// The type only takes 12 bytes, without extra padding.
-#[derive(Clone, Copy, Debug, PartialOrd, Default, PartialEq, Eq)]
+#[derive(Clone, Copy, Debug, Default, PartialEq, Eq)]
pub struct Int96 {
value: [u32; 3],
Review Comment:
That will lead to misaligned `i64` fields. From the ML it seems like this is
a fix for legacy data while trying to convince the spark crowd to stop
producing `INT96` timestamps. As such, I'd opt for the minimum set of changes
needed and leave `value` as it was.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
