scovich commented on code in PR #7704:
URL: https://github.com/apache/arrow-rs/pull/7704#discussion_r2154906594
##########
parquet-variant/src/variant.rs:
##########
@@ -276,60 +252,81 @@ impl<'m> VariantMetadata<'m> {
}
/// Get the offsets as an iterator
- pub fn offsets(&self) -> impl Iterator<Item = Result<Range<usize>,
ArrowError>> + 'm {
+ #[allow(unused)]
+ pub(crate) fn offsets(&self) -> impl Iterator<Item = Range<usize>> + 'm {
+ self.offsets_checked().map(Result::unwrap)
+ }
Review Comment:
I'd love to just delete this method, and fold `offsets_checked` into
`fields_checked`.
Do we have a plausible use case for using offsets in isolation, that
justifies keeping it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
