carpecodeum commented on code in PR #7670:
URL: https://github.com/apache/arrow-rs/pull/7670#discussion_r2156191959
##########
parquet-variant/src/variant.rs:
##########
@@ -337,9 +405,15 @@ impl<'m, 'v> VariantArray<'m, 'v> {
}
pub fn values(&self) -> Result<impl Iterator<Item = Variant<'m, 'v>>,
ArrowError> {
- todo!();
- #[allow(unreachable_code)] // Just to infer the return type
- Ok(vec![].into_iter())
+ let len = self.len();
Review Comment:
this should be resolved now, i hope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
