pitrou commented on code in PR #46886:
URL: https://github.com/apache/arrow/pull/46886#discussion_r2162013324
##########
cpp/src/parquet/decoder.cc:
##########
@@ -2233,23 +2294,22 @@ class ByteStreamSplitDecoder<FLBAType> : public
ByteStreamSplitDecoderBase<FLBAT
PARQUET_THROW_NOT_OK(builder->Reserve(num_values));
- // Decode into intermediate buffer.
- uint8_t* decode_out = this->EnsureDecodeBuffer(values_to_decode);
+ // 1. Decode directly into the FixedSizeBinary data buffer, packed to the
right.
Review Comment:
Note to self: I should perhaps add the same optimization to the other
BYTE_STREAM_SPLIT decoders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
