alamb opened a new pull request, #7771:
URL: https://github.com/apache/arrow-rs/pull/7771

   (This is a draft for now until I have a PR that shows how it works)
   
   # Which issue does this PR close?
   
   - Part of https://github.com/apache/arrow-rs/issues/7762
   
   # Rationale for this change
   
   I would like to reuse some part of the existing filtering logic for 
https://github.com/apache/arrow-rs/issues/7762. However, it is currently split 
into a bunch of free functions that all take a `FilterPredicate` argument. By 
making them methods on `FilterPredicate` I will be able to reuse the code
   
   # What changes are included in this PR?
   
   1. Move `filter_*` methods into functions on `FilterPredicate` (note all the 
methods are still private so this doesn't change the public API)
   
   # Are these changes tested?
   Existing CI covers them functionally
   
   I will run performance tests to ensure we don't mess up performance
   
   
   # Are there any user-facing changes?
   There are no intended user facing changes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to