rok commented on pull request #9841: URL: https://github.com/apache/arrow/pull/9841#issuecomment-816605545
> > Should we also add a benchmark? I see other kernels have them. > > Yes we should. It can be in another pr. I've added the benchmark. I hope I've not missed something there. > Thanks for persistent in improving this pr. Will review soon. Thanks for the feedback! :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org