alamb commented on pull request #9936:
URL: https://github.com/apache/arrow/pull/9936#issuecomment-816613802


   > Random though: I think that we would benefit from not writing a test on 
Context to test the SQL planner. It could be easier to identify which tests are 
testing what by writing unit tests more specialized to the component that they 
affect, as they usually declare the API behavior and are easier to find.
   
   @jorgecarleitao  I think the core of the problem is that the tests in 
`context.rs` are largely end to end tests of DataFusion rather than tests for 
the `ExecutionContext` itself. I think they ended up in context.rs because that 
is typically the main entry point to run queries.
   
   What would you think about refactoring the non `ExecutionContext` specific 
tests to some other file (perhaps the `tests/sql.rs` end to end test?)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to