friendlymatthew commented on code in PR #7740:
URL: https://github.com/apache/arrow-rs/pull/7740#discussion_r2164653330
##########
parquet-variant/src/builder.rs:
##########
@@ -420,100 +472,152 @@ impl Default for VariantBuilder {
///
/// See the examples on [`VariantBuilder`] for usage.
pub struct ListBuilder<'a> {
- parent: &'a mut VariantBuilder,
- start_pos: usize,
+ parent_buffer: &'a mut VariantBuffer,
+ field_metadata_dictionary: &'a mut FieldMetadataDictionary,
offsets: Vec<usize>,
+
+ buffer: VariantBuffer,
Review Comment:
I was thinking about this as well -- and yes, now that we can build large
lists, it'll be worthy of profiling and benchmarking 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
