WillAyd commented on code in PR #46715:
URL: https://github.com/apache/arrow/pull/46715#discussion_r2167558361
##########
cpp/src/arrow/meson.build:
##########
@@ -422,6 +422,8 @@ arrow_lib = library(
include_directories: arrow_includes,
dependencies: arrow_deps,
install: true,
+ gnu_symbol_visibility: 'hidden',
+ cpp_shared_args: ['-DARROW_EXPORTING'],
Review Comment:
FWIW its not really necessary to define a macro like this on non-Windows
platforms. We could alternatively just simplify the ARROW_EXPORT macro to
always use default symbol visibility.
I figure that change is better left to a follow up though, so for now going
with CMake feature parity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
