friendlymatthew commented on code in PR #7782:
URL: https://github.com/apache/arrow-rs/pull/7782#discussion_r2167759945
##########
parquet-variant/src/to_json.rs:
##########
@@ -103,23 +105,34 @@ fn write_decimal_i64(
///
/// # Examples
///
+///
/// ```rust
/// # use parquet_variant::{Variant, variant_to_json};
/// # use arrow_schema::ArrowError;
-/// let variant = Variant::Int32(42);
+/// let variant = Variant::String("Hello, World!");
Review Comment:
Hi, I just realized there's nothing stopping a user from creating a
`Variant::String` that could've been a `Variant::ShortString`.
This isn't the end of the world, but using the `String` variant adds 4
unnecessary bytes to the header, which could accumulate in loops or large
payloads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
