scovich opened a new pull request, #7785:
URL: https://github.com/apache/arrow-rs/pull/7785

   # Which issue does this PR close?
   
   * Part of https://github.com/apache/arrow-rs/issues/6736
   
   # Rationale for this change
   
   Follow-up to https://github.com/apache/arrow-rs/pull/7670, which 
accidentally introduced a lossy to-string conversion for variant decimals. 
   
   # What changes are included in this PR?
   
   Use integer + string operations to convert decimal values to string, instead 
of floating point that could lose precision.
   
   Also, the `VariantDecimalXX` structs now `impl Display`, which greatly 
simplifies the to-json path. A new (private) macro encapsulates the to-string 
logic, since it's syntactically identical for all three decimal sizes.
   
   # Are these changes tested?
   
   Yes, new unit tests added.
   
   # Are there any user-facing changes?
   
   The `VariantDecimalXX` structs now `impl Display`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to