LanHikari22 commented on code in PR #7733: URL: https://github.com/apache/arrow-rs/pull/7733#discussion_r2168021393
########## parquet_derive/src/lib.rs: ########## @@ -50,45 +50,52 @@ mod parquet_field; /// Example: /// /// ```no_run Review Comment: Thank you for your feedback! Yes I have removed `no_run`. It is not necessary. I have added to the README that we can test the doctests using ```sh cargo test --doc -- --show-output ``` This could be integrated into a CI pipeline on commit, or otherwise to ensure they remain working. I also updated the example itself to be more comprehensive, writing to file and reading it back and checking content is identical. If any of that fails, the above command will trigger an error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
