kou commented on code in PR #46922: URL: https://github.com/apache/arrow/pull/46922#discussion_r2174405568
########## cpp/src/arrow/compute/CMakeLists.txt: ########## @@ -114,6 +114,46 @@ function(ADD_ARROW_COMPUTE_TEST REL_TEST_NAME) ${ARG_UNPARSED_ARGUMENTS}) endfunction() +# This function is used to add a custom main to the benchmarks in order +# to initialize the compute kernels registry before running them. +# This is necessary for benchmarks that use compute kernels that are not +# part of libarrow. +# It will also link the compute libraries to the benchmark target. +function(ADD_ARROW_COMPUTE_BENCHMARK REL_TEST_NAME) Review Comment: Yes. See also: https://github.com/apache/arrow/pull/39824#discussion_r1505939524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org