mapleFU commented on code in PR #46940: URL: https://github.com/apache/arrow/pull/46940#discussion_r2174912377
########## cpp/src/parquet/arrow/reader_internal.cc: ########## @@ -344,7 +344,7 @@ void AttachStatistics(::arrow::ArrayData* data, using ArrowCType = typename ArrowType::c_type; - auto statistics = metadata->statistics().get(); + auto statistics = metadata->statistics(); Review Comment: `metadata->statistics()` returns `std::shared_ptr<Statistics>`, and `.get()` leaves a raw pointer, which's lifetime relies on `metadata` internal... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
