alamb commented on code in PR #7825: URL: https://github.com/apache/arrow-rs/pull/7825#discussion_r2174931199
########## parquet/src/arrow/array_reader/mod.rs: ########## @@ -45,7 +45,8 @@ mod struct_array; #[cfg(test)] mod test_util; -pub(crate) use builder::ArrayReaderBuilder; +// Note that this crate is public under the `experimental` feature flag. Review Comment: If we are going to make it non experimental we I think we need to add tests (e.g. doctest) or something that shows how the public API is being used so we don't break it in the future. I need to think about what the implications of making it pub are -- it may make more sense to do that if/when we have finally sorted out how what it takes to turn on filter pushdown -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
