friendlymatthew commented on code in PR #7808:
URL: https://github.com/apache/arrow-rs/pull/7808#discussion_r2175679053
##########
parquet-variant/src/builder.rs:
##########
@@ -567,7 +564,8 @@ impl<'a> ListBuilder<'a> {
pub struct ObjectBuilder<'a, 'b> {
parent_buffer: &'a mut ValueBuffer,
metadata_builder: &'a mut MetadataBuilder,
- fields: BTreeMap<u32, usize>, // (field_id, offset)
+ fields: Vec<(u32, usize)>, // (field_id, offset)
+ field_id_to_index: HashMap<u32, usize>, // (field_id, index to `fields`)
Review Comment:
Thank you @scovich, I just pushed up a change and it proves to be a nice
improvement.
<img width="1058" alt="Screenshot 2025-06-30 at 2 42 06 PM"
src="https://github.com/user-attachments/assets/8a204b4c-e06e-476f-9085-521369620dfb";
/>
<img width="1036" alt="Screenshot 2025-06-30 at 2 42 15 PM"
src="https://github.com/user-attachments/assets/7844b633-2980-424c-bc72-7fc098c5ff25";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
