jackyhu-db opened a new pull request, #3073:
URL: https://github.com/apache/arrow-adbc/pull/3073

   # PR Description
   
   ## Description
   
   This PR sets  the `ConnectTimeoutMilliseconds ` of  `DatabricksConnection` 
with `TemporarilyUnavailableRetryTimeout` when 
`TemporarilyUnavailableRetryTimeout` is greater than 
`ConnectTimeoutMilliseconds` to make sure it can continue the retry when 
`ConnectTimeoutMilliseconds` is lower than `TemporarilyUnavailableRetryTimeout`.
   
   ### Changes
   - Updated `DatabricksConnection:ValidateOptions` to set 
`ConnectTimeoutMilliseconds` with `TemporarilyUnavailableRetryTimeout` when 
`TemporarilyUnavailableRetryTimeout` is greater than 
`ConnectTimeoutMilliseconds` and `TemporarilyUnavailableRetry` is enabled
   
   ### Motivation 
   
   The default value of `ConnectTimeoutMilliseconds` is 30 seconds (see 
[here](https://github.com/apache/arrow-adbc/blob/main/csharp/src/Drivers/Apache/Hive2/HiveServer2Connection.cs#L43)),
 which is lower than the default value (900s) of 
`TemporarilyUnavailableRetryTimeout`. If client does not set this, it will 
timeout after 30s, this is normally lower than the Databricks cluster startup 
time, so the client/user may get the timeout error when opening a connection on 
an idle cluster.
   
   ### Testing
   
   - E2E test by opening a connection and run a query on a cluster that has 
been stopped


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to