harshmotw-db commented on PR #7783: URL: https://github.com/apache/arrow-rs/pull/7783#issuecomment-3025591614
@alamb @scovich Yeah, I think that makes sense. For now, we could do away with the decimal type in json_to_variant and always use double, and soon replace it when the custom parser is ready. That being said, the `preserve_order` flag ensures that object keys are inserted into the Variant in the order that they appear. Removing it would result in a behavior difference between Arrow and Spark's parse_json expression. I don't think that makes a logical difference but the binaries would look different as the keys would be sorted in the Arrow library. Just to clarify, the number parsing was never a hard problem - that just overcomes the rust_decimal dependency, but the fact that `serde_json` doesn't give you strings without the `arbitrary_precision` flag that needs to be done away with. But I guess the tape decoder PR implements all of JSON parsing internally so that's great. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
