pitrou commented on code in PR #46017:
URL: https://github.com/apache/arrow/pull/46017#discussion_r2179597718
##########
cpp/src/parquet/encryption/internal_file_decryptor.cc:
##########
@@ -148,9 +150,9 @@ InternalFileDecryptor::GetColumnDecryptorFactory(
// The column is encrypted with its own key
const std::string& column_key_metadata = crypto_metadata->key_metadata();
const std::string column_path =
crypto_metadata->path_in_schema()->ToDotString();
- std::string column_key = GetColumnKey(column_path, column_key_metadata);
+ const SecureString& column_key = GetColumnKey(column_path,
column_key_metadata);
- return [this, aad, metadata, column_key = std::move(column_key)]() {
+ return [this, aad, metadata, column_key = column_key]() {
Review Comment:
Hmm, we must capture the column key by value here. It's not obvious that
it's what `column_key = column_key` does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
