WillAyd commented on PR #45272: URL: https://github.com/apache/arrow/pull/45272#issuecomment-3028343713
OK taking a look there. The main difference I noticed is that `ArraySpan` exposes its `buffers` class member as an `BufferSpan` array whereas `ArrayData` exposes it as a vector of shared pointers to a buffer. Additionally, the `ArraySpan` has a `dictionary` class method whereas `ArrayData` has a `dictionary` class member that is a shared pointer. Do you think its worth trying to align the signatures of these elements to make templating easier, or should I perhaps use templating to disable the `Visit` methods in `RangeDataEqualsImpl` where those are currently being accessed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
